search

typst / citationberg

A library for parsing CSL styles.
Apache License 2.0
36 stars 7 forks source link

Add `subsequent` Param to `Name::is_supressed` #3

Closed DerDrodt closed 11 months ago

DerDrodt commented 11 months ago

Will be used in fixing bug typst/hayagriva#111

This PR adds a parameter to Name::is_supressed, which allows a different behavior when writing names for a subsequent citation, per the name options in the CSL spec.

After merging, I will update hayagriva accordingly.

reknih commented 11 months ago

Thank you!

(I updated the description in the PR so merging does not close https://github.com/typst/hayagriva/issues/111 just yet)

DerDrodt commented 11 months ago

(I updated the description in the PR so merging does not close typst/hayagriva#111 just yet)

Thank you for catching that!

DerDrodt commented 11 months ago

One more quick question: To use this in hayagriva, citationberg needs a new release. Should it be a major one? This is technically a breaking change.