Closed CosmicHorrorDev closed 1 year ago
Yeah, forgot about that test. I think keeping the limit at 15 for 32-bit makes more sense, 7 just isn't enough.
I should probably add it to CI too, but it's pretty easy to test different arches with Miri
$ cargo +nightly miri test --target i686-unknown-linux-gnu # 32-bit
$ cargo +nightly miri test --target sparc64-unknown-linux-gnu # 64-bit BE
It didn't pick up on any UB with either of those, so you've been doing good!
I'll open a PR to fix that test later today
Good to know!
I was doing some testing (got a lot planned for that btw), and I noticed that the
test_mem_size
test failsIt looks like the inline limit on 32-bit LE systems is still 15. I'd love to submit a PR to fix things, but I wasn't sure if the right approach was to use a smaller limit on 32-bit systems or to keep a larger limit even though the word size is smaller