Closed CosmicHorrorDev closed 1 year ago
Base: 86.68% // Head: 86.68% // No change to project coverage :thumbsup:
Coverage data is based on head (
d8c31a9
) compared to base (ebcbaa1
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Nice!
I figured it would be worthwhile to start digging through issues reported in the advisory-db. So far it hasn't found anything interesting, but this includes areas that could have issues from future optimizations (primarily avoiding extra bounds/capacity checking)
This is just the first set since there's more I would like to add (namely around panicking in either
clone()
ordrop()
, but that seems fine so far). Common sources of issues seem to beSend
orSync
bounds: already fixeddebug_assert!
s wouldn't hurtclone()
issue. All the lifetimes seem right, so far#[repr(Rust)]
layout:EcoVec
seems appropriately#[repr(C)]
and running withRUSTFLAGS="-Zrandomize-layout"
didn't find any issuesStill have more auditing to do, but so far things seem very solid :+1: