Closed CosmicHorrorDev closed 1 year ago
Patch coverage has no change and project coverage change: -3.69
:warning:
Comparison is base (
ebcbaa1
) 86.68% compared to head (7eaa477
) 82.99%.:exclamation: Current head 7eaa477 differs from pull request most recent head c24c145. Consider uploading reports for the commit c24c145 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks like the reduced coverage is just from src/tests.rs
no longer being covered which is to be expected :grin:
Thanks!
Coverage reduction shouldn't fail CI in my opinion. Besides, do you have plans for further testing soon? I'd like to publish to crates.io soon, but would be a shame if you found UB immediately after.
I agree. I just publish to codecov without the integration which is what's failing CI. Could be worth switching over to that
I've got more testing I would like to do, but it's going to be a slow trickle since I'm very pressed on time lately. I think it's fine to go ahead and push a release and then just yank with new releases if UB is found
I haven't found anything since the incorrect Send
and Sync
bounds, so it should be reasonably robust at this point
Resolves #18
This follows the described restructuring, renaming, and switches the unit tests to integration tests. The only change that the latter involved was switching a single call from
.extend_from_byte_slice()
to.extend_from_slice()
since.extend_from_byte_slice()
isn't included in the public API (and should get tested well by theEcoString
tests anyways)