typst / ecow

Compact, clone-on-write vector and string.
Apache License 2.0
208 stars 16 forks source link

Setup GitHub actions for CI #5

Closed CosmicHorrorDev closed 1 year ago

CosmicHorrorDev commented 1 year ago

This sets up and action that runs on:

This enforces:

laurmaedje commented 1 year ago

For now, I would prefer to remove clippy and MSRV completely. Maybe I'll give clippy another try and see about it then. :)

CosmicHorrorDev commented 1 year ago

Done and done

CosmicHorrorDev commented 1 year ago

Notably I switched cargo clippy -- -D warnings to a cargo check -- -D warnings as a heads up

laurmaedje commented 1 year ago

Thanks for all your pull requests!

CosmicHorrorDev commented 1 year ago

Thanks for the library! I hope to use it in the future :D

CosmicHorrorDev commented 1 year ago

Forgot that cargo check can't be passed Rust flags. I'll throw up a PR to fix that

laurmaedje commented 1 year ago

Doesn't cargo check get executed anyway through cargo test?

CosmicHorrorDev commented 1 year ago

I don't normally deny warnings on cargo test because I'm less concerned about warnings that crop up there, but I try to keep cargo check output clean, so that it's easy to notice any bug-prone warnings on future incompat notices