search

typst / packages

Packages for Typst.
Apache License 2.0
516 stars 313 forks source link

note-me:0.3.0 #1002

Closed FlandiaYingman closed 3 days ago

FlandiaYingman commented 1 week ago

I am submitting

Description: Add custom icon support.

FlandiaYingman commented 1 week ago

Oh it's committed as submodule, will fix it later.

ngoetti commented 6 days ago

Oh it's committed as submodule, will fix it later.

How can you create a pull request with the files instead of a submodule. I have not seen that option and also found nothing on stackoverflow which is so weird to me.

elegaanz commented 6 days ago

You have to make sure you remove the .git folder of your package before adding it to the index when copying your package. With the git command line, the steps to follow would be something like:

cd typst/packages
cp -r ~/my-package packages/preview/my-package/0.1.0
rm -rf packages/preview/my-package/0.1.0/.git/ # This is the important part, otherwise Git will assume you want to create a submodule, and do it for you
git add packages/preview/my-package/0.1.0/
# Then, commit and push as you would usually do
FlandiaYingman commented 4 days ago

Thanks! It's done now.

elegaanz commented 3 days ago

Thanks