search

tyrannicaltoucan / vim-deep-space

An intergalactically friendly color scheme for Vim.
MIT License
297 stars 25 forks source link

Add option to honor terminal transparency #11

Open Utagai opened 5 years ago

Utagai commented 5 years ago

From what I can tell, this color scheme won't honor terminals that are using a transparent (or any other background, really) themselves, since it will write over it with its own background color.

Looking at this issue, it seems like the way to get this fixed is to patch the color scheme we are using Neovim.

This PR adds an option, deepspace_transparent, which causes the colorscheme to not apply a background for Normal. I believe both ctermbg and guibg are necessary, but I could be wrong.

Also, there may be better ways to do this, feel free to change the diff here. Also, maybe this is not something you want, feel free to reject this and I'll personally use my fork. Or, if deep space can support this already, let me know how!

Utagai commented 5 years ago

I realize that another option is that we can export the HL() function as a public API. This will actually let users customize the color scheme even further if they ever want to change a few color choices here and there. This is also what the one colorscheme does, so it isn't unprecedented.

oblitum commented 4 years ago

Most colorschemes don't provide an option like that, almost everyone patch that from .vimrc.

Utagai commented 4 years ago

Like I said in my second comment, it's not unprecedented, and in all honesty, just because no one else has done something, doesn't mean you shouldn't.

That being said, like I've also mentioned, I don't feel strongly about merging this or not. I'm perfectly willing to just use my own fork of this.

oblitum commented 4 years ago

I just provided a comment because the wording that "it doesn't honor" isn't sensible. It's not a standard practice, so there's nothing to honor there. It sure can be made into a non-default esoteric option, no problem.

Utagai commented 4 years ago

Ah, I gotcha. Well, wordings and semantics aside, I think my point is simply that if a user of this color scheme has a transparent terminal background, they're going to be inconvenienced. Please feel free to edit the title as you see fit! I don't really care either way. 🙂

I'll let you or whoever make the decision on this PR, it doesn't cost me anything to keep it here. Feel free to close/reject/merge/etc.