search

tyrasd / osmtogeojson

convert osm to geojson
http://tyrasd.github.io/osmtogeojson/
MIT License
683 stars 112 forks source link

flatProperties status in 3.0.0 #100

Open yohanboniface opened 5 years ago

yohanboniface commented 5 years ago

Hi @tyrasd !

Seems to me that the minified version of osmtogeojson.js still defaults to flatProperties: false in the 3.0.0-beta.3 version available in the NPM registry.

Also, when I look at the file in the repository I still see flatProperties:!1.

Am I missing something? :)

Thanks!

Ref: https://github.com/umap-project/umap/issues/641

tyrasd commented 5 years ago

ooh, it must be that I forgot to update the browserified&minified version before pushing the 3.0.0-beta(s?) to github/npm (it works as expected in the non pre-built code) and must have accidentally pushed an old version of the compiled file. I'll check it later today when I'm on the PC from which I did that.

//edit: yeah, that must be the case: the minified file has not been changed at all since the last version of the 2.* code was released. Compare the file date with https://github.com/tyrasd/osmtogeojson/releases ;)

carstenhag commented 5 years ago

Hey, no clue if relevant but all, but yeah:

As per the README, flatProperties defaults to false. As per https://github.com/tyrasd/osmtogeojson/blob/0d6190a2c3d23b3ce0ab9b302199834894334727/index.js#L39 and my experience (had to search for this bug) it's set to true per default on the cli.

We just need to fix the readme, right?

markusstraub commented 12 months ago

I noticed that while the osmtogeojson CLI called without parameters creates a GeoJSON with flat properties, when using the --ndjson parameter the resulting GeoJSON is not flat. And unfortunately I don't see an option to specifiy the "flatness" via CLI?