tyrasd / osmtogeojson

convert osm to geojson
http://tyrasd.github.io/osmtogeojson/
MIT License
683 stars 112 forks source link

Inconsistencies in versions and Types #112

Closed runette closed 1 year ago

runette commented 4 years ago

There seems to be some problems with the npm package osmtogeojson@3.0.0-beta.4 .

This is what you get when you ask for osmtogejson@latest.

This package comes with a node_modules directory (don't think that is what you intended) - which includes a copy of @types/geojson that then means the types are different to those in my own copy of @types/geojson that is used in the rest of my code. It took about 5 hours of my time to work out what was going on!

Also : this package has a different index.d.ts from the one in this repository that incorrectly sets all members of OsmToGeoJSONOptions to mandatory - when they should be optional. This means that you cannot just one option (like flatProperties=false) - you have to set THEM ALL.

Speaking of which - I know that the changelog highlights that breaking change but the README.md still says that the default is flatProperties=false! If this is now the default distro - then you should really change the README.

BTW- thanks for a really awesome tool :)