tyrasd / osmtogeojson

convert osm to geojson
http://tyrasd.github.io/osmtogeojson/
MIT License
693 stars 113 forks source link

[Snyk] Security upgrade xmldom from 0.1.31 to 0.5.0 #122

Closed tyrasd closed 2 years ago

tyrasd commented 3 years ago

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 556/1000
Why? Recently disclosed, Has a fix available, CVSS 5.4
XML External Entity (XXE) Injection
SNYK-JS-XMLDOM-1084960
No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: xmldom The new version differs by 157 commits.
  • f763b00 xmldom version 0.5.0
  • d4201b9 Merge pull request from GHSA-h6q6-9hqw-rwfv
  • a4d717c Update MDN links in readme.md (#188)
  • e984b3f Update @ stryker-mutator/core -> ^4.4.1 - devDependencies (#184)
  • c762161 Update stryker monorepo (major) (#140)
  • fd47c51 Fix breaking preprocessors' directives when parsing attributes (#171)
  • baa67f5 Update xmltest -> ^1.5.0 - devDependencies (#182)
  • 64c7388 fix(dom): Escape `]]>` when serializing CharData (#181)
  • b73a965 Update eslint-config-prettier -> ^7.2.0 - devDependencies (#179)
  • 21bc17e Switch to (only) MIT license (#178)
  • ad773c9 test: Use toBe/toStrictEqual instead of toEqual (#175)
  • 23608d9 chore: Add karfau as contributor (#177)
  • dbd2171 Export DOMException; remove custom assertions; etc. (#174)
  • 8698e6b Update eslint-config-prettier -> 7 - devDependencies (#165)
  • 7aa75c7 Update nodemon -> ^2.0.7 - devDependencies (#170)
  • 8236db1 build(deps): bump node-notifier from 8.0.0 to 8.0.1 (#169)
  • 484005e Update eslint -> ^7.18.0 - devDependencies (#162)
  • c33b2f5 Update eslint-plugin-prettier -> ^3.3.1 - devDependencies (#164)
  • 5d13108 Update actions/setup-node action -> 2 - action (#167)
  • 7f32da6 Update prettier -> ^2.2.1 - devDependencies (#163)
  • d4040a7 build(deps): bump ini from 1.3.5 to 1.3.8 (#166)
  • f7b44d9 Update eslint -> ^7.12.1 - devDependencies (#157)
  • 7493052 Update jest -> ^26.6.3 - devDependencies (#161)
  • 2107a91 Update jest -> ^26.6.2 - devDependencies (#159)
See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

kachkaev commented 3 years ago

@tyrasd 🙏

kachkaev commented 3 years ago

Meanwhile, to mitigate this issue and https://github.com/tyrasd/osmtogeojson/pull/117, I added the following section to my package.json:

  "resolutions": {
    "@mapbox/geojson-rewind": "^0.5.0",
    "xmldom": "^0.5.0"
  },

The lib still works for my workflow, so if they are breaking changes, they must be limited to some edge cases only.

kachkaev commented 3 years ago

Replaced by #127