tyrasd / overpass-turbo

A web based data mining tool for OpenStreetMap using the Overpass API.
https://overpass-turbo.eu
Other
937 stars 133 forks source link

Search for camp_site fails #478

Open JCS45 opened 4 years ago

JCS45 commented 4 years ago

A known camp_site is not found ... Using: node [tourism=camp_site] ({{bbox}}); out;

image

mmd-osm commented 4 years ago

Did you realize that your screenshot shows a way, in your query you're asking for nodes. Those are entirely different things.

JCS45 commented 4 years ago

Hi I am happy to use the program it feels intuitive to use and the output helps me chekking that other info that I get is actually correct & complete. I am a new user of the program and may use the selection parameters wrongly setting up the wrong search filter, but the output is so close to the expected that I think that that part is OK. Therefore I think that there can be errors in your input - or that the search parameters is wrong anyway ? Because I knew what to expect I found 2 examples of things that were not displayed as results. When I realised that I had a problem spotting the tourism=camp_site I tried other searches in order to perhaps find those places anyway - so I must have mixed up the screenshots in the process, sorry. Below is the 2 examples that I found (hopefully without making errors):

[image: image.png] The Police station on Zahrtmannsvej 44, Rønne, Bornholm [image: image.png] The camp_site Camp Hverringe At least for the camp_site the last OSM update is 2 years old so the data is not new.

Hope that you can find the time to help me find the full correct list of results. Would it be of any help if I found more examples ?

Best regards, Jens

Den ons. 5. aug. 2020 kl. 19.09 skrev mmd notifications@github.com:

Did you realize that your screenshot shows a way, in your query you're asking for nodes. Those are entirely different things.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tyrasd/overpass-turbo/issues/478#issuecomment-669316357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPB42HOGUEAU2LMCRTEAGDR7GG4TANCNFSM4PRZ2SLA .

mmd-osm commented 4 years ago

Unfortunately, your images you've tried to post don't show up here on Github, and you didn't provide the exact queries you were running. There's no way to help you based on this information.

JCS45 commented 4 years ago

I am not used to the way that Github is using mails. Lets try again:

1) The Police station on Zahrtmannsvej 44, map showing closeup of the area in Rønne, Bornholm node [amenity=police] ({{bbox}}); out;

2) The Camp Hverringe, map showing closeup of the area on Northeast Fyn close to Kerteminde node [tourism=camp_site] ({{bbox}}); out;

Den tor. 6. aug. 2020 kl. 09.49 skrev Jens C. Skinneholm < skinneholm@gmail.com>:

Hi I am happy to use the program it feels intuitive to use and the output helps me chekking that other info that I get is actually correct & complete. I am a new user of the program and may use the selection parameters wrongly setting up the wrong search filter, but the output is so close to the expected that I think that that part is OK. Therefore I think that there can be errors in your input - or that the search parameters is wrong anyway ? Because I knew what to expect I found 2 examples of things that were not displayed as results. When I realised that I had a problem spotting the tourism=camp_site I tried other searches in order to perhaps find those places anyway - so I must have mixed up the screenshots in the process, sorry. Below is the 2 examples that I found (hopefully without making errors):

[image: image.png] The Police station on Zahrtmannsvej 44, Rønne, Bornholm [image: image.png] The camp_site Camp Hverringe At least for the camp_site the last OSM update is 2 years old so the data is not new.

Hope that you can find the time to help me find the full correct list of results. Would it be of any help if I found more examples ?

Best regards, Jens

Den ons. 5. aug. 2020 kl. 19.09 skrev mmd notifications@github.com:

Did you realize that your screenshot shows a way, in your query you're asking for nodes. Those are entirely different things.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tyrasd/overpass-turbo/issues/478#issuecomment-669316357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPB42HOGUEAU2LMCRTEAGDR7GG4TANCNFSM4PRZ2SLA .

mmd-osm commented 4 years ago

The police station https://www.openstreetmap.org/way/219502852 is again a way.

You need to query with way[amenity=police] ({{bbox}});out geom; to get any results. Using node will not return any results, because that police station is not a node.

Please do some editing first in OSM to get familiar with the OSM data model. I cannot explain that here in detail.

JCS45 commented 4 years ago

Thanks for your help. My conclusion is then that the OSM in DK is marginally correct and needs updates (garbage in => garbage out) (as I found approx. 130 of expected 140 police sites - then a difference in definition must exist for the rest). I had hoped/expected that the definitions were more uniform/correct in OSM.

Den tor. 6. aug. 2020 kl. 11.30 skrev mmd notifications@github.com:

The police station https://www.openstreetmap.org/way/219502852 is again a way.

You need to query with way[amenity=police] ({{bbox}});out geom; to get any results. Using node will not return any results, because that police station is not a node.

Please do some editing first in OSM to get familiar with the OSM data model. I cannot explain that here in detail.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tyrasd/overpass-turbo/issues/478#issuecomment-669819940, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPB42CEYQARK22II4ICREDR7JZ2BANCNFSM4PRZ2SLA .

mmd-osm commented 4 years ago

Please read up more on OSM before jumping to conclusions. Mappers are free to model objects as way or node or relation. This is definitely not garbage!

HolgerJeromin commented 4 years ago

Or just use the wizard with tourism=camp_site as the search text. This will search for all type of objects.

ajburley commented 4 years ago

Thanks a lot for posting and replying. I had the same confusion. I am also pretty new to OSM and reading through this issue saved me from raising an issue of my own and making myself look stupid.

In my case I was looking for nightclubs, which can be modelled as either a way (building) or a node (within a building). (Personally I prefer the second approach as it lets you model more than one amenity in the building.) In my city there is a mixture of modelling approaches for this. I got all of them by doing (accepting the auto-repair suggestion which frankly I have no idea about):

way
  [amenity=nightclub]
  ({{bbox}});
/*added by auto repair*/
(._;>;);
/*end of auto repair*/
out;

node
  [amenity=nightclub]
  ({{bbox}});
out;

I guess you could do something similar for your campsite case.

I think the confusion for me was that when opening Overpass Turbo for the first time, you get an example query to look for drinking water, so I just thought I can replace amenity=drinking_water with amenity=nightclub, but actually it's not quite that simple.

JCS45 commented 4 years ago

The change that Holger made in the wizard automated this already - now includes node, way & relation. Thanks to the maintainers helping an amateur this fast. Rgds, Jens

søn. 9. aug. 2020 kl. 12.45 skrev ajburley notifications@github.com:

Thanks a lot for posting and replying. I had the same confusion. I am also pretty new to OSM and reading through this issue saved me from raising an issue of my own and making myself look stupid.

In my case I was looking for nightclubs, which can be modelled as either a way (building) or a node (within a building). (Personally I prefer the second approach as it lets you model more than one amenity in the building.) In my city there is a mixture of modelling approaches for this. I got all of them by doing (accepting the auto-repair suggestion which frankly I have no idea about):

way [amenity=nightclub] ({{bbox}}); /added by auto repair/ (._;>;); /end of auto repair/ out;

node [amenity=nightclub] ({{bbox}}); out;

I guess you could do something similar for your campsite case.

I think the confusion for me was that when opening Overpass Turbo for the first time, you get an example query to look for drinking water, so I just thought I can replace amenity=drinking_water with amenity=nightclub, but actually it's not quite that simple.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tyrasd/overpass-turbo/issues/478#issuecomment-671036195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPB42CZ3TMMAST62UYDPITR7Z45JANCNFSM4PRZ2SLA .

stephan75 commented 4 years ago

See the OSM wiki about

https://wiki.openstreetmap.org/wiki/Elements

for more information.

HolgerJeromin commented 4 years ago

I think the confusion for me was that when opening Overpass Turbo for the first time, you get an example query to look for drinking water, so I just thought I can replace amenity=drinking_water with amenity=nightclub, but actually it's not quite that simple.

Thanks for your explanation!

Perhaps the "main" problem is a default example which does not include ways. It does not need itself, but when used as a learning example.

mnalis commented 3 months ago

I think this has been improved in the years by wizard, and can be closed now?

JCS45 commented 3 months ago

It’s OK to close this (I have not been using the tool lately) Rgds. Jens

søn. 14. jul. 2024 kl. 16.22 skrev Matija Nalis @.***>:

I think this has been improved in the years by wizard, and can be closed now?

— Reply to this email directly, view it on GitHub https://github.com/tyrasd/overpass-turbo/issues/478#issuecomment-2227366800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPB42BJ2DA3LACP2HCFIMDZMKCRNAVCNFSM6AAAAABK3G3D26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGM3DMOBQGA . You are receiving this because you authored the thread.Message ID: @.***>