search

tyrauber / census_api

A Ruby Gem for querying the US Census Bureau API
MIT License
30 stars 9 forks source link

Allow user to specify dataset vintage (year) #14

Closed guyshechter closed 10 years ago

tyrauber commented 10 years ago

@guyshechter Great addition of functionality! I moved the setting of the default vintage to the find method in the request class (for testing purposes), and wrote specs around datasets and vintages. Bumped the gem to v1.0.5.

Thanks for the pull request!

guyshechter commented 10 years ago

Thanks @tyrauber. Then the example I added to the Readme

@client = CensusApi::Client.new(API_KEY, {vintage: 2012, dataset: 'SF1'}) # specific vintage (year)

will not work. Can you update with an example of how to pass the vintage in the find function?

tyrauber commented 10 years ago

@guyshechter Missed that. Sorry. Added back the ability to assign vintage at the client level, as documented in the readme, and updated the specs accordingly. Version bump to v.1.0.6. Thanks.

guyshechter commented 10 years ago

@tyrauber Thanks. Looks like it is working now.