search

tyrauber / census_api

A Ruby Gem for querying the US Census Bureau API
MIT License
30 stars 9 forks source link

Fixing deprecations and speed up #18

Closed MetricMike closed 8 years ago

MetricMike commented 8 years ago

Thank you so much for creating this wrapper. While working with this, I took a pass at upgrading some of the outdated libraries.

Old test suite ~40 seconds. New test suite ~20 seconds.

tyrauber commented 8 years ago

Thanks for the contribution, @MetricMike. I appreciate you updating the libraries and specs. Where exactly are the breaking changes? The result is the same? Why the necessity to bump to v2.0.1?

MetricMike commented 8 years ago

Overly aggressive versioning on my part.

Technically, httprb doesn't support Ruby < 2, so that could break for older apps relying on census_api. Running specs on 1.9.3 seems to work fine though, so I dropped the version down to 1.1.0

tyrauber commented 8 years ago

You also added the rvm files to .gitignore, perfect. Just remove the updated authorship and this is good to go. If you are interested in being an author of this gem and helping with the development and maintenance going forward, shoot me an email and we can discuss adding you as a contributor. Thanks again for the update. Solid PR.

MetricMike commented 8 years ago

If I end up doing more work on it, will definitely shoot you an email, but for now I took my name off.

You're my first public PR so thanks for being so helpful during the process =)

On Mon, May 16, 2016 at 12:51 PM, Ty Rauber notifications@github.com wrote:

You also added the rvm files to .gitignore, perfect. Just remove the updated authorship and this is good to go. If you are interested in being an author of this gem and helping with the development and maintenance going forward, shoot me an email and we can discuss adding you as a contributor. Thanks again for the update. Solid PR.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tyrauber/census_api/pull/18#issuecomment-219478760

tyrauber commented 8 years ago

Not a problem. Great work! Most appreciated. Merged and pushed v1.1.0.