search

tyrauber / census_api

A Ruby Gem for querying the US Census Bureau API
MIT License
30 stars 9 forks source link

License missing from gemspec #8

Closed bf4 closed 11 years ago

bf4 commented 11 years ago

Some companies will only use gems with a certain license. The canonical and easy way to check is via the gemspec via e.g. 

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

There is even a License Finder to help companies ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. Including a license in your gemspec is a good practice, in any case.

How did I find you?

I'm using a script to collect stats on gems, originally looking for download data, but decided to collect licenses too, and make issues for missing ones as a public service :) https://gist.github.com/bf4/5952053#file-license_issue-rb-L13 So far it's going pretty well

beechnut commented 11 years ago

What do you think, @tyrauber? My usual default is GPL.

bf4 commented 11 years ago

FWIW, you currently have the MIT license sitting in your repo https://github.com/tyrauber/census_api/blob/master/LICENSE.txt

beechnut commented 11 years ago

Opened a PR. https://github.com/tyrauber/census_api/pull/9

tyrauber commented 11 years ago

I have always gone with MIT - albeit incorrectly, apparently. PR accepted.