Closed dblock closed 6 years ago
@dblock, In the 4 years of this gem's life, I have had to rewrite stock_quote multiple times due to API's being decommissioned, abandoned or paywalled. With this last rewrite, I opted to simplify the structure of the gem as much as possible to provide a working / testable example, with as little dependencies, code and cognitive overhead as possible. A gem that is easy to develop, test and use - even in the event of a major API / Provider change.
If it can be made more simple, in design or architecture, or more stable, with better tests and error messages, I'll accept all contributions as long as they don't add significant complexity or dependencies.
I appreciate your feedback and contribution. Good luck with google-finance-ruby-client.
First, thanks for writing this gem. I stared using it in https://github.com/dblock/slack-market.
Then I started by trying to improve stock_quote (see #48 for example, then I wanted more consistent error handling, etc.), but gave up as the fetching of the data was just too messy between trying to deal with CSV, JSON and HTML returns in one place - it was easier to make a new gem from scratch. That's now https://github.com/dblock/google-finance-ruby-client. It uses Faraday and Hashie::Dash for base structures making things much cleaner.
Consider deprecating this gem and moving over to my rewrite, happy to put google-finance-ruby-client to an org, share maintenance, etc.