tyrcho / openshift-cartridge-play2

Play2 In OpenShift as a cartridge
https://github.com/tyrcho/openshift-cartridge-play2
37 stars 42 forks source link

properties deprecated in config file and start command #28

Closed almothafar closed 8 years ago

almothafar commented 8 years ago

Hi,

I just have note about deprecated properties in config file and start up command, i'm not sure why they are not updated, since some deprecated from 2.4 , and i'm working with 2.5 now, examples not all :

in command:

I understand that you want to cover all versions from 2.x to 2.5 but maybe good idea to have some conditions maybe to load specific template or maybe provide legacy cartridge and bleeding edge cartridge?

Its sound like deprecation not hurt, but actually in play framework, it is, like language properties, i understand that I can replace them with my own, but I just want to give my feedback and suggestions anyway.

fpirola commented 8 years ago

Hi @almothafar , at the moment I am writing this comment, the config file properties comes with the current default play-scala template. For this reason I will not change config file. I will not update the command -DapplyEvolutions.default=true in order to cover old versions.

Thank you for your feedback and sorry for the late response, Best regards