search

tyrells / dosbox-svn-shaders

GLSL Shaders for DOSBox SVN r4319 and later
65 stars 5 forks source link

Double-quotes aren't parsed in DOSBox Staging on Windows #7

Closed kcgen closed 3 years ago

kcgen commented 3 years ago

xbr-parse-problem

Replacing the "space separated items", such as:

#pragma parameter XBR_EQ_THRESHOLD "Eq Threshold" 0.6 0.0 2.0 0.1
#pragma parameter XBR_LV2_COEFFICIENT "Lv2 Coefficient" 2.0 1.0 3.0 0.1

with the following, fixes the issue:

#pragma parameter XBR_EQ_THRESHOLD Eq_Threshold 0.6 0.0 2.0 0.1
#pragma parameter XBR_LV2_COEFFICIENT Lv2_Coefficient 2.0 1.0 3.0 0.1
tyrells commented 3 years ago

Hi @kcgen. The #pragma lines aren't actually being used in the shader code, and have just been kept around so that users know the recommended/min/max values that they can use to adjust these parameters. The actual values used in the code are the #define statements later in the code.

This being the case, I have commented out the #pragma code completely. Let me know if this fixes your issue.

kcgen commented 3 years ago

Capture2

Tested a handful and all are working nicely :-)

Thank you @tyrells!