search

tyrion / gridsome-plugin-netlify-cms-paths

Fix markdown image paths to work with Netlify CMS
10 stars 5 forks source link

store.addContentType to store.addCollection #4

Closed samuelhorn closed 4 years ago

samuelhorn commented 5 years ago

Fixed on of the two errors in my issue #3

tyrion commented 4 years ago

Hello, thanks for the PR, however that is not the correct way to solve the issue. This PR would break compatibility with whoever didn't update Gridsome, so in my opinion is not an improvement on the current state.

I guess something like store.addCollection || store.addContentType could work. You can have a look at how the plugins in the official gridsome repo were migrated (I think they do something similar).

If you don't mind making the change and testing it, I would be happy to merge it.