Upgrade dependencies for Node v12

tyroprogrammer / learn-react-app

Application that will help you learn React fundamentals. Install this application locally - there's tutorial, code snippets and exercises. The main objective of this project is to help you get off the ground with React!

MIT License

3.65k stars 328 forks source link

Upgrade dependencies for Node v12 #38

Closed karlhorky closed 5 years ago

karlhorky commented 5 years ago

Thanks for this project! Really helpful to have more educational material in the community!

This PR upgrades fsevents to 1.2.9 to support Node v12 as documented in fsevents/fsevents#274.

It requires a major upgrade (2 -> 3) of react-scripts too due to the locked version number in their dependency. The list of breaking changes seemed to be short and the application works after the upgrade.

tyroprogrammer commented 5 years ago

@karlhorky - Thanks for the PR.