tyrrellsystems / node-red-contrib-serial-modbus

This node is now maintained from @leifnel's fork
https://github.com/leifnel/node-red-contrib-serial-modbus
Apache License 2.0
7 stars 13 forks source link

Removed unused done callback of close event listener #9

Closed jonasgreen88 closed 7 years ago

jonasgreen88 commented 7 years ago

If the listener of a close event accepts a done callback it must be called. Else Node-red will hang, waiting for the callback to be called, while stopping flows where this node is included. In this particular case, without any asynchronous calls in the close listener, there is no need to use the done callback.

hardillb commented 7 years ago

Thanks for spotting that, I probably just added it out of habit when I added the other on close listener. I've got a couple of other updates to do so I'll merge this in with those and push a new version

jonasgreen88 commented 7 years ago

You're welcome. Looking forward for the new version of this node!