Open aubreywullschleger opened 7 years ago
Thanks, I was keeping the blocks of the page together as I thought it would make it easier for your review. The same goes for my putting line breaks in my paragraph text, I thought it would be easier for the reviewer. I know it makes no difference to how is displayed. I'll be sure to not do that again.
Simplify! Make sure to nest, indent, and space your HTML elements consistently. For example, all sibling elements should be indented the same amount, your h2s and image tags are a great example of good indentation. https://github.com/tyrrellv/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L10-L11
The p tags should be wrapping the end tags consistently as well. https://github.com/tyrrellv/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L27-L31
Also, in your paragraph tags there is no need to start text on a new line as it won't affect your page's output, Example: lines 14 and 15 can move to 13, lines 21 and 22 can move to 20, lines 28, 29, and 30 can move to line 27. https://github.com/tyrrellv/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L13-L15 https://github.com/tyrrellv/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L20-L22 https://github.com/tyrrellv/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L27-L30