search

tyrrellv / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #5

Open aubreywullschleger opened 7 years ago

aubreywullschleger commented 7 years ago

Grade: Needs Improvement

Summary: Great work on this project! I really appreciate your concise HTML and CSS.

A few things to work on here:

  1. Modularize your HTML and CSS by moving your inline-styles to your style.css file.
  2. Keep your HTML consistent and easy to read by nesting, indenting, and spacing your code consistently.
  3. Also, make sure to use valid HTML elements (see link for valid elements in comment).

Next, I would refactor your code to account for the suggestions I've made. Then as a further challenge I would research how to use responsive design techniques like media queries to make your code responsive at all screen widths. I think this is a challenge you are ready for based on your work here! See here: https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries and here: https://css-tricks.com/snippets/css/media-queries-for-standard-devices/ for how to use media queries.

tyrrellv commented 7 years ago

Thanks for the feedback, it is greatly appreciated. I thought the project was for us to showcase what we had learned so I have CSS and inline html code to show that I understood what we had learned. I thought that is what we were trying to demonstrate with the project. I know it can be done via CSS and I thought my coding showed that I knew. Are you asking me to change the html and css?