Closed somini closed 8 years ago
@somini Hmm, there is already similar global variable g:cfi_javascript_show_assignment
.
How about adding g:cfi_javascript_show
like this?
let g:cfi_javascript_show = ["assignment", "varname", "funtype", "funname", "funargs", "funbody"]
g:cfi_javascript_show_assignment
should be also deprecated if this variable is merged.
Yeah, it's not sustainable to just have a bunch of one-off switches.
I'll follow your advice and implement that.
Thanks! :)
ah, maybe Dictionary is preferrable rather than List.
extend()
.let g:cfi_javascript_show = {"assignment": 1, "varname": 1, "funtype": 1, "funname": 1, "funargs": 1, "funbody": 1}
Here's a first implementation. I'll test this tomorrow.
I've fixed this.
This has a lot of junk commits, I'll squash this into a single commit and force push to this PR.
This has a lot of junk commits, I'll squash this into a single commit and force push to this PR.
Okay, no problem. However I don't care if there are a lot of commits in PR :)
@somini is it okay to merge this?
Yes, I've been using it regularly and haven't run into any issues yet. If anyone opens new issues related to this, please ping me.
This has a lot of junk commits, I'll squash this into a single commit and force push to this PR.
How is this going?
I also feel this PR has no problems. I was just waiting you squash this. (I'm okay if you choose you don't do that)
It's already 1 commit only, you can merge it.
@somini Okay, now merged it! Thanks!
This adds a way to show only the function name in the Javascript cfi.
I think this could be optimized, but the original code is fast, no harm done.