Reimplement python parsing to account for nested functions/classes

[jerojasro]

The previous implementation did not work properly when there were empty lines between blocks of code inside a function.

I reimplemented it so:

• indent detection is robust against empty lines: if it finds an empty line (or only whitespace), it returns the indent level of the previous line
• function name detection moves upwards in the file until the beginning of the file, and keeps track of every enclosing declaration

Now the output returned shows the fully qualified function name (MyClass.my_function) if it applies

[tyru]

Please give an example.

[jerojasro]

This exemplifies the issue:

class AccountViewTestCase(BaseTestCase):

    def test_new_account(self):
        name = 'John'  # cfi#get_func_name() works fine when the cursor is here

        phone_number = '3551122333'  # cfi#get_func_name() doesn't show anything when the cursor is here

[tyru]

In addition to my review, in your example, at line 2, cfi#get_func_name() returns empty string. But it should be AccountViewTestCase (same as line 3). Can you fix this?

[jerojasro]

I made changes to:

• incorporate your suggestion of using indent/prevnonblank. Thanks!
• remove code that is no longer being used: I deleted the code that was validating corner cases of erroneous indentation, while accounting for multiline strings. I think it is no longer necessary.

I still haven't thought of a way of solving this situation:

class Blah:
# cursor here, asume it's an empty line; cfi should say "Blah", but thinks it is not inside any function
  pass

I'll give it some more thought today.

[jerojasro]

In addition to my review, in your example, at line 2, cfi#get_func_name() returns empty string. But it should be AccountViewTestCase (same as line 3). Can you fix this?

Fixed. I think it's ready for you to have another look.

[tyru]

class Blah:
# cursor here, asume it's an empty line; cfi should say "Blah", but thinks it is not inside any function
  pass

For such case, cfi.vim must inspect if the line is a comment or not. I don't want to inspect source code deeply, because there should be many corner cases.

And in this code, it seems to work fine. I think it is enough.

class Blah:
  # cursor here, has indent; cfi says "Blah"
  pass

[tyru]

Thanks! 🎉