search

tyru / open-browser-github.vim

Open GitHub URL of current file, etc. from Vim editor (supported GitHub Enterprise)
BSD 3-Clause "New" or "Revised" License
173 stars 14 forks source link

:OpenGithubProject ignores argument #29

Open mwgkgk opened 5 years ago

mwgkgk commented 5 years ago

With this .vimrc:

set nocompatible

call plug#begin('~/.vim/bundle/')

Plug 'tyru/open-browser.vim'
Plug 'tyru/open-browser-github.vim'

call plug#end()

:OpenGithubProject always opens current repo, even when called with an argument.

E.g. calling :OpenGithubProject tyru/open-browser.vim opens mwgkgk/dotfiles, if I call it from my .vimrc :) If called outside of a valid repo, open-browser prints the following complaint:

open-browser doesn't know how to open 'Usage: hub browse [-uc] [[<USER>/]<REPOSITORY>|--] [<SUBPAGE>]'.
tyru commented 4 years ago

Have you installed hub command? In my environment (no hub command), I couldn't reproduce this (argument is recognized, and no error message).

mwgkgk commented 4 years ago

The situation seems to be exactly as you described!

Not reproducible with hub removed.

Is this an issue that is possible to fix by configuration? Do you intend to have hub be incompatible with :OpenGithubProject ? It might overlap in some regards as well.

In general, thank you for your work on Vim plugins!