search

tyssen / Deetector

ExpressionEngine device- and feature-detection add-on
15 stars 1 forks source link

Devices Variables output nothing #2

Closed hql287 closed 11 years ago

hql287 commented 11 years ago

Hi Tyssen

It's great to see your add-on here. I've tried and it works (almost) as expected. I can't find a way to make the Device's variables work. The only variable that outputs value is {hi_res_capable}.

Also, I've modified your sample template to a tables based one - css from Twitter Bootstrap. Feel free to use if you find it helpful: https://gist.github.com/hungle88/5642633

Thanks & Keep up the good work!

tyssen commented 11 years ago

I just took a look again and {device} was also working fine for me. I took a look back through the Detector library and camel-casing the variable name in the plugin also got {device_full} working too.

Not getting any luck with device_major, device_minor or device_version, but looking back through the library I found a comment in a read me that says "in select cases the device information will also be captured" but doesn't elaborate on what those cases are so perhaps it's a device-specific thing.

Maybe it would be better to just leave them out from the plugin altogether.

hql287 commented 11 years ago

Hi John

What's the PHP requirement for this plugin to work properly?

Thanks!

tyssen commented 11 years ago

The Detector library itself doesn't have any stated requirements so they would just be the requirements to run EE itself.

On Saturday, 25 May 2013 at 2:56 AM, hungle88 wrote:

Hi John What's the PHP requirement for this plugin to work properly? Thanks!

— Reply to this email directly or view it on GitHub (https://github.com/tyssen/Deetector/issues/2#issuecomment-18417042).

hql287 commented 11 years ago

Thanks, John.