tythe-protocol / tythe

1% of Global R&D to Open Source Maintenance
Apache License 2.0
27 stars 2 forks source link

Deps: Want to be able to find cross-language deps at every node in graph #8

Closed aboodman closed 5 years ago

aboodman commented 5 years ago

Currently, tythe will find Golang deps and NPM deps on whatever root it is run on, but it will not find Go deps that include node deps, like for example webtythe currently does. This is a very common pattern, so we are missing a lot.

I think that in order to do this, we need to crawl the graph manually rather than shelling out to e.g., npm list or go mod list. Which is fine, it would be better to lack the dependencies anyway.

aboodman commented 5 years ago

Fixed by https://github.com/tythe-protocol/tythe/commit/0b0d36fea02a88d9bf94b7bfe34aebe32491cde0