tytydraco / LADB

A local ADB shell for Android!
https://play.google.com/store/apps/details?id=com.draco.ladb
Other
1.78k stars 473 forks source link

Enable secure shell #16

Closed gaycodegal closed 3 years ago

gaycodegal commented 3 years ago

I wanted to run a permission revoke command from this app and got 'neither user nor current process has android.permission.REVOKE_RUNTIME_PERMISSIONS' for example the command I was trying to run looked like pm revoke com.offendingapp android.permission.INTERNET there's a secure mode you can run ADB in that allows you to do such things

gaycodegal commented 3 years ago

Oh yeah I'm using a non root pixel 3 with the play store version of your app

tytydraco commented 3 years ago

Hi! Looks like this is just an issue with the command and not with LADB itself. The reason you see this is probably because you can't revoke internet permissions from an app since they are an implicit permission (not requiring user confirmation).

tytydraco commented 3 years ago

Feel free to reopen the issue if you need more help!

gaycodegal commented 3 years ago

oh you're right, i hadn't attempted this from the computer, which returns a different message Permission android.permission.INTERNET requested by com.offendingapp is not a changeable permission type; I think the point is more that it would be nice if LADB didn't return neither user nor current process has android.permission.REVOKE_RUNTIME_PERMISSIONS and instead was able to do the proper command, resulting in the "not changeable" error. That being said, probably not worth fixing