tytydraco / LADB

A local ADB shell for Android!
https://play.google.com/store/apps/details?id=com.draco.ladb
Other
1.81k stars 474 forks source link

Suggestion: using notification to enter the adb pair code #57

Open tiann opened 2 years ago

tiann commented 2 years ago

telegram-cloud-photo-size-5-6280784557208874390-y

I think it is more convenient than split screen :)

tiann commented 2 years ago

I am sorry, duplicate: #43

tiann commented 2 years ago

It seems that #43 just add a shortcut :(

Some system can not split screen for Settings app, it is better to use notification channel

NonstickAtom785 commented 2 years ago

It seems that #43 just add a shortcut :(

Some system can not split screen for Settings app, it is better to use notification channel

This is an amazing idea! And it's not too hard to add to the apps interface either. Question is can we allow the app to use an overlay instead to read the screen? It would enable searching the UI for the pairing code element. The only issue with this is that you kinda have to enable drawing over system apps. And that's a security threat in most cases.

tiann commented 2 years ago

I think if user needs the adb shell permission, security threat for "screen overlay" is not so important, because adb shell permissions are much more dangerous

NonstickAtom785 commented 2 years ago

May I ask what type of phone you have that doesn't allow for split screen? And I also have an app that you might be able to use to see if the phone really does not have split screen support.

tiann commented 2 years ago

It is vivo's originOS, i am glad to test it

NonstickAtom785 commented 2 years ago

Shortcut Maker

Alright I did this the other day... With this app you can make a split screen apps shortcut on the homescreen. Just choose LADB and Settings app as the splitscreenable apps and try it out. If it doesn't work... I'll be disappointed in Vivo.

Oh and if that doesn't work try desktop mode app. In the developer options you can make apps open as little tabs. :D

tiann commented 2 years ago

It might be a little complicated for me to access the Google Play in vivo devices, please wait some minutes..

NonstickAtom785 commented 2 years ago

It might be a little complicated for me to access the Google Play in vivo devices, please wait some minutes..

No worries I just found this:

The new OS gets an improved multi-window interaction. You can swipe up from the bottom left corner of the display to resize an app into a smaller window. You will also be able to drag/ drop this window for a split-screen configuration.

And here's the apkpure apk...

tiann commented 2 years ago

aaaaa

It doesn't work.. here is the gif, am i doing wrong?

NonstickAtom785 commented 2 years ago

Oh no your not. It is working though. Once you it in splits screen you screen you can do so much more. Have you tried the other thing I linked?

Also issue #43 is not the same thing. In that issue they asked for a Quick Settings tile. In other words a quick link to open the LADB app I believe. It is not the same.

(Side note are you having to use translate to read my messages?)

tiann commented 2 years ago

Oh no your not. It is working though. Once you it in splits screen you screen you can do so much more. Have you tried the other thing I linked?

when i try to split Settings, the system just make a toast: "该应用不支持分屏", which means "this app dones't support split screen", i will try the other you linked

Also issue #43 is not the same thing. In that issue they asked for a Quick Settings tile. In other words a quick link to open the LADB app I believe. It is not the same.

Actually i think #43 is just what i say, Shizuku is an app, it also has a wireless adb mode, but when enter the pair code, it make a notification, and there is a EditText in notification, you can enter the pair code in notification, no need to split the screen.

(Side note are you having to use translate to read my messages?)

I can read English :)

NonstickAtom785 commented 2 years ago

Alright then at the bottom of developer options there is a force allow apps to be resizable button. That might fix it.

tiann commented 2 years ago

Alright then at the bottom of developer options there is a force allow apps to be resizable button. That might fix it.

It works!

NonstickAtom785 commented 2 years ago

Alright then at the bottom of developer options there is a force allow apps to be resizable button. That might fix it.

It works!

Awesome sauce! Glad that helped yuh out. Now I'm going to move on. Hope the dev actually adds something like this to the apps though.

Missmeanass1970 commented 2 years ago

I am using Samsung Galaxy A52 and the LADB is stuck on waiting for device respond. I am new to this, can anyone help? I am trying to not use a computer with it.

NonstickAtom785 commented 2 years ago

I am using Samsung Galaxy A52 and the LADB is stuck on waiting for device respond. I am new to this, can anyone help? I am trying to not use a computer with it.

Hey this one is simple. You need to clear the app data and then reopen it. After that you should be able to go through the steps again. I'm thinking of adding a function that clears the last known connected device to prevent this from happening so much. It's a bit annoying.

tytydraco commented 2 years ago

@tiann Ohhhhh I see what you guys meant with the Shizuku notification haha! I am thinking I will just switch to Shizuku as the backend at this point, it does a lot of the same thing and it does it better. But I do not want to disturb existing users who are happy with the current method... Maybe I will give the user the option to pick one.

teou1 commented 2 years ago

I'd prefer a choice (and not installing shizuko for a 1 time action if i am not going to use shizuko for other things).

boognish-rising commented 2 years ago

I didn't want to open up a separate issue just to ask a simple question and I thought this might be an appropriate place for it, but if it's not, I can split it off.

@tytydraco - I just noticed that you mention on the project's home page that Shizuku and LADB are incompatible. I don't know how I missed that until now and I wonder how many of the issues I was running into might have been stemming from the fact that I had Shizuku installed as well....

Anyway, is it enough for the wireless debugging connection to be forgotten for one or the other depending on which app one is looking to use at any given moment or must the application not in use be completely uninstalled in order to use the other? So for example, let's say I want to use LADB but and have Shizuku installed, can I simply forget the Shizuku wireless debugging connection and move forward with LADB without issue and would the same be true the other way around? Or maybe if forgetting the connection isn't quite enough, clearing data/cache for whichever app isn't presently needed?

If it needs to be completely uninstalled every time, so be it but that would be a pretty big inconvenience. One I'm willing to put up with if necessary but that's why I'm inquiring, to determine whether or not it is.

Side note - if uninstallation is unavoidable, adding at least the option to use Shizuku in tandem with LADB as you mentioned above would be that much more of a welcomed change/addition.

tytydraco commented 2 years ago

Hmmm, I haven't tested. Try with just removing the connection and let me know if that works.