tytydraco / LADB

A local ADB shell for Android!
https://play.google.com/store/apps/details?id=com.draco.ladb
Other
1.69k stars 462 forks source link

Stopped working in Android 13 #84

Open ShebeerPrince opened 1 year ago

ShebeerPrince commented 1 year ago

I have been using this app for a very long time to enable ADB WI-FI in my Pixel 6 wirelessly without use of a PC.

But it looks like this stopped working since A13. Tried resetting but no luck.

boognish-rising commented 1 year ago

I was dropping in to check whether there was already an issue submitted for this and/or confirm whether or not LADB is functioning on A13 or not. I seem to be encountering all sorts of issues since upgrading, so I wasn't sure if it was on me/ my device or whether it was the app or what. But even though this is just one issue submitted without any comments or responses in the week that it's been since it was submitted, it suggests that it's not my phone's fault, anyway. I used it very recently but can't remember if it was before or after upgrading to 13T.

Anyway, consider this a second/another report that LADB seems to be broken on Android 13. Unrooted Google Pixel 6 Pro.

This is a super bummer of a development to be sure, but I'm more afraid of the impact it'll have on the app's Play Store rating, as it already has a criminally low rating for what it is and the amazing convenience it provides when it is working properly, which in my opinion outweighs any breakages from major updates and/or random bug etc. Though, I suppose I should bite my tongue and wait to see how severe this particular breakage is and long it'll be before it's solved.

PS - I noticed that there's no beta offering on the Play Store like there is for most apps. I haven't looked around here, but either way if you need beta testers that are running 13, I'd be happy to contribute in that way, or any other for that matter.

Keep up the awesome work @tytydraco!

tytydraco commented 1 year ago

I have been using this app for a very long time to enable ADB WI-FI in my Pixel 6 wirelessly without use of a PC.

But it looks like this stopped working since A13. Tried resetting but no luck.

Hi, usually what I suggest is for people to clear the LADB app data and remove all wireless debugging connections, then reboot, then pair again. It usually works after that. Can you confirm?

tytydraco commented 1 year ago

I was dropping in to check whether there was already an issue submitted for this and/or confirm whether or not LADB is functioning on A13 or not.

I think it's working, but yes some people have emailed about A13 problems. But I don't think anybody has said it still wasn't working after the fixup steps. I'm thinking it might be caused when the user updates and gets the old LADB files.

This is a super bummer of a development to be sure, but I'm more afraid of the impact it'll have on the app's Play Store rating, as it already has a criminally low rating for what it is and the amazing convenience it provides when it is working properly, which in my opinion outweighs any breakages from major updates and/or random bug etc.

True...

PS - I noticed that there's no beta offering on the Play Store like there is for most apps. I haven't looked around here, but either way if you need beta testers that are running 13, I'd be happy to contribute in that way, or any other for that matter.

Oh definitely, I just don't have a beta set up yet but that could be a good avenue to go down.

Truthfully the biggest issue is that I can't compile another ADB binary for Android. The guy who did it did it for a very old version of ADB which is why we don't have 32 bit support for adb pair commands. I've tried to compile adb but it's ridiculously difficult. I think we might need to give it another try.

Keep up the awesome work @tytydraco!

Thank you :)

ShebeerPrince commented 1 year ago

I have been using this app for a very long time to enable ADB WI-FI in my Pixel 6 wirelessly without use of a PC.

But it looks like this stopped working since A13. Tried resetting but no luck.

Hi, usually what I suggest is for people to clear the LADB app data and remove all wireless debugging connections, then reboot, then pair again. It usually works after that. Can you confirm?

I tried. Exactly what you suggested.

But it didn't work. Then after n number of attempts all of a sudden it worked. Then after my next reboot a few days later, it didn't work... Again, worked after a few attempts.

So I really have no idea what's going on and how to report the issue to you because I don't have a clear cut situation to explain.

Sometimes it works. Sometimes it just keeps waiting. Sometimes LADB even exits after success, but without activating the ADB.

tytydraco commented 1 year ago

Sometimes it works. Sometimes it just keeps waiting. Sometimes LADB even exits after success, but without activating the ADB.

Hmmm... The issue is I can't force Android to connect to the ADB server, I have to wait for it to connect on its own. And that's usually why the hang up happens. I'll try to find another way to maybe force a connection. It's difficult when I can't replicate it though.

ShebeerPrince commented 1 year ago

Sometimes it works. Sometimes it just keeps waiting. Sometimes LADB even exits after success, but without activating the ADB.

Hmmm... The issue is I can't force Android to connect to the ADB server, I have to wait for it to connect on its own. And that's usually why the hang up happens. I'll try to find another way to maybe force a connection. It's difficult when I can't replicate it though.

It's fine since you understood what the issue is. Take your time. Hope you can figure it out asap.

Thank you for the app.

boognish-rising commented 1 year ago

I have been using this app for a very long time to enable ADB WI-FI in my Pixel 6 wirelessly without use of a PC.

But it looks like this stopped working since A13. Tried resetting but no luck.

Hi, usually what I suggest is for people to clear the LADB app data and remove all wireless debugging connections, then reboot, then pair again. It usually works after that. Can you confirm?

I tried. Exactly what you suggested.

But it didn't work. Then after n number of attempts all of a sudden it worked. Then after my next reboot a few days later, it didn't work... Again, worked after a few attempts.

So I really have no idea what's going on and how to report the issue to you because I don't have a clear cut situation to explain.

Sometimes it works. Sometimes it just keeps waiting. Sometimes LADB even exits after success, but without activating the ADB.

This has been more or less my experience too. However, much more of the not working stage. Although I did notice that like you mentioned, it would successfully connect to the server only to exit more or less immediately. I wish I could remember what the messages were or that I would have had the presence of mind to take a little 30 second screen recording so I could pass it along to you since you'd actually be able to do something with the info. But without having done that I can only say that what @ShebeerPrince described sounds very similar to what I've experienced ≈90% of all attempts to use LADB. I wish that meant that the other ≈10% of the time I successfully connected but that hasn't been the case. I may have once. I know I was able to use it recently to run a command for the MatLog app. I just don't know if that was before or after upgrading to 13 but I believe it was after. It suggests there is a path to success; a particular combination of conditions present on the phone, when they occur simultaneously, LADB works. We just need to figure out what those conditions are... Probably network state related but who knows? On the flip side, there are clearly plenty of conditions under which it won't work correctly but I choose to look at this situation with a glass half full perspective😃🤞

ShebeerPrince commented 1 year ago

... I wish I could remember what the messages were or that I would have had the presence of mind to take a little 30 second screen recording so I could pass it along....

I think the message @boognish-rising mentioned is "shell dead" / "fell into shell" something like that.

This is a message which usually (previously) shows when ADB is activated, just before LADB closes. This is how LADB app used to work on my device. Even though it says something is "dead", it used to activate ADB successfully (That's how LADB used to work in A12). Just like the dev mentioned it somewhere in the app or GitHub description.

boognish-rising commented 1 year ago

... I wish I could remember what the messages were or that I would have had the presence of mind to take a little 30 second screen recording so I could pass it along....

I think the message @boognish-rising mentioned is "shell dead" / "fell into shell" something like that.

This is a message which usually (previously) shows when ADB is activated, just before LADB closes. This is how LADB app used to work on my device. Even though it says something is "dead", it used to activate ADB successfully (That's how LADB used to work in A12). Just like the dev mentioned it somewhere in the app or GitHub description.

Yes, I believe you're exactly right. I feel like there may have been a little bit more to it but that was definitely part of it anyway/what I was referencing

teou1 commented 1 year ago

Just dropped in to say it works with my pixel 4a on android 13. It sometimes cannot turn on the debugging automatically, but hey i have a quick settings button for that, i just click it before starting ladb.

P.s. LADB is convenience tool. If for some reason it doesn't work at all in your case and you a desperate and can't wait for a fix, you can achieve the same thing with installing Termux from f-droid (not the playstore!), Then type pkg install android-tools and here is your adb. You still have to pair with splitscreen and connect, see adb help.

driftywinds commented 1 year ago

Wanted to add to this by saying that the split screen method does not work for OxygenOS 13 (Android 13) anymore because the settings app does not support split screening, so I was wondering if there was another way to pair the app with wireless debugging? Thanks for the work you have put in @tytydraco!!

boognish-rising commented 1 year ago

Edit - I'll try to be helpful instead of only ragging on OnePlus - it's a long shot but maybe under Developers Options -> toggling any of the following could maybe change the default behavior of OxygenOS where settings / multi window is concerned:

Fortunately the problems I originally faced with A13 have seemingly dissipated. I've had no problems lately, LADB connects very quickly and stays connected. The weird interaction with ChromeOS is still there but on the plus side, the app works great on ChromeOS too (when it's not stealing wireless ADB connection attempts that are meant for my phone)

Somewhat unrelated and of no help to you with the issue mentioned but I remember a time not long ago when OxygenOS was by far the best Android skin available and arguably even better than a pure/stock Android experience you'd get from a Pixel device (with the exception of Pixel Exclusives, but even with the Pixel Exclusives, an argument could still be made for OxygenOS' superiority). The fact that they gutted it and essentially replaced it with ColorOS and slapped the recognizable OxygenOS name on it is a travesty

PS can you tell that I used to be an avid OnePlus user/advocate and that I'm slightly salty about the direction they've taken the company in recent years?

Cr4z33 commented 8 months ago

Has there been any improvement on this issue lately?

I am facing the same issue on a Samsung Galaxy S22 Ultra with Android 13 and One UI v5.1.

And yes I've been using LADB a lot in the past so I know what usually to do. 😉