search

tytydraco / LADB

A local ADB shell for Android!
https://play.google.com/store/apps/details?id=com.draco.ladb
Other
1.69k stars 462 forks source link

Shizuku API integration #99

Open dyingjedi opened 1 year ago

dyingjedi commented 1 year ago

Shizuku API integration

GL513 commented 1 year ago

Personally, I don't think this is needed since Shizuku already has a section telling you how to use a terminal app, such as Termux with Shizuku. LADB has a bit of a different goal, not needing any more applications other than itself.

dyingjedi commented 1 year ago

Although the point still stands. as to being able to run both side by side if done and made to use shizuku. as of now you have to shutdown Shizuku to run LADB. Lame. makes device vulnerable, having to shut down shizuku.

hyperio546 commented 1 year ago

Although the point still stands. as to being able to run both side by side if done and made to use shizuku. as of now you have to shutdown Shizuku to run LADB. Lame. makes device vulnerable, having to shut down shizuku.

How the hell does it make device vulnerable?

GL513 commented 1 year ago

https://gitlab.com/sunilpaulmathew/ashell https://f-droid.org/en/packages/in.sunilpaulmathew.ashell/

hyperio546 commented 1 year ago

https://gitlab.com/sunilpaulmathew/ashell https://f-droid.org/en/packages/in.sunilpaulmathew.ashell/

What are you trying to tell?

GL513 commented 1 year ago

https://gitlab.com/sunilpaulmathew/ashell https://f-droid.org/en/packages/in.sunilpaulmathew.ashell/

What are you trying to tell?

It does just what LADB does, but with shizuku, so it technically has better compatibility than LADB because the shell can run just as long as shizuku is running, even when not on WiFi.

mirh commented 12 months ago

If we are talking about using the adb privilege shizuku has.. I don't really see much of a point. It has basically the same pros and cons of what LADB already does. Ok actually, I just checked their "older android" launch script and it doesn't seem to involve wireless adb. So, I suppose you never know what fancier/lazier/stranger users could prefer or have available.

On the other hand, if LADB could exploit the (potential) root permissions of shizuku for a root shell it would be great. But I'm not sure how convenient or pointless that would be, over just requesting root permissions yourself directly.