tyuyang / pe

0 stars 0 forks source link

Flaw: Allergens not stored after exit #5

Open tyuyang opened 1 year ago

tyuyang commented 1 year ago

If the feature for adding allergens is added, there should be a method for saving the information for allergens, since firstly people will assume that allergens are saved and then get the wrong information with the command "possible recipes" after exiting.

nus-se-script commented 1 year ago

Team's Response

User Guide already clearly stated that allergens are not saved in the current iteration

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear what information is saved and what is not

UG only mentioned that ingredients would be saved by the CLI app but nothing is stated about other information like allergens. Upon testing, i realized that allergen is not saved which could be an issue since allergen can cause health complications if the user were to forget.

image.png

image.png


[original: nus-cs2113-AY2223S2/pe-interim#261] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

User Guide already clearly stated that allergens are not saved in the current iteration

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Note that team did not give a proof of why the bug is considered a duplicate. The original bug is more of a misunderstanding with the tester since the tester did not see that part in the user guide. Mine was a feature flaw / suggestion for the team to add a save allergen feature.


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** While I agree that the assumption would not occur if the user guide is read, since the saving feature was implemented for one of the features, it is reasonable for the user to assume that the allergens will be saved too. Therefore, there is a need to implement such a saving feature so that the application stays consistent, or possibly to implement a warning in the application that specifically warns that the allergens list is not saved.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** I do not see how this bug is a functionality bug, since the application performs exactly as how the user guide defines. This is a feature flaw since omitting this feature can easily cause misunderstandings to occur with the user.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]