tyuyang / pe

0 stars 0 forks source link

Application should warn users when corrupted savefile is detected #6

Open tyuyang opened 1 year ago

tyuyang commented 1 year ago

Since a corrupted save file is considered an error, there should at least be a warning or error message shown when such defects are detected. Currently, the app simply fails to load the ingredient list without giving a reason.

In addition, since there is no self correcting measures in place for corrupted save files, the user is unable to tell why the program fails to save their information even after restarting the program. This means that they will not be able to fix the program, despite the method being on the user guide, precisely because they do not know the reason why the program is failing

nus-pe-script commented 1 year ago

Team's Response

No instructions on how to corrupt the save file to produce the specified behavior

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: Corrupting the "quantity" parameter, having 2 entries in the savefile with the same "name", corrupting the label of any of the parameters will all result in the ingredients list not being loaded.

image.png

image.png

In the images above, the top image is the text in the savefile, and the bottom image is the commands and output. After "bye" is called and the user runs the application again, running the command ingredients list will not load the ingredient list.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]