tyuyang / pe

0 stars 0 forks source link

Application does not have a list of valid ingredients #8

Open tyuyang opened 1 year ago

tyuyang commented 1 year ago

The user is unable to find out what all the valid ingredients are, since it is not listed anywhere in the user guide and from what I can see, you cannot retrieve a list of valid ingredients in the app itself. This becomes an issue when minor spelling mistake come into play, since 'eggs' is not considered a valid ingredient, and so the user is unable to find out what is the valid syntax for that ingredient conveniently (ie. without having to trial and error).

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add ingredient function does not work for some ingredients

When add tomato /qty 10 or add potato /qty 5 is called, an error message is produced. Not sure if there is a pre-defined list of ingredients that I have follow, but can't seem to find to find it any where in the user guide.

image.png

image.png


[original: nus-cs2113-AY2223S2/pe-interim#1589] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

According to the UG section on Search Ingredients shown in the screenshot above, users can use the ingredients search command to see our "pre-defined list of ingredients". Maybe we would implement a feature to allow users to add their own known ingredients into the list in future iterations therefore this issue is not in scope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Clearly not a duplicate, the two bugs are 2 separate issues. My issue is a feature flaw talking about how there is no pre-defined list of valid ingredients, while the 'original' bug is about how some ingredients are not considered valid ingredients.


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Team responded: "According to the UG section on Search Ingredients shown in the screenshot above, users can use the ingredients search command to see our "pre-defined list of ingredients".". This is pretty much completely false, as seen in this picture: ![image.png](https://raw.githubusercontent.com/tyuyang/pe/master/files/9397e4b3-027e-4453-b365-6bfaefe5a9e5.png) For context, first input has no trailing space, second has 1 trailing space, third has 2 trailing space. So there is no way to get a pre-defined of ingredients. The response should be accepted as this is a valid feature flaw that will affect the users of the product significantly enough that it should have been in version 1 of the product (basically not notInScope).
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/tyuyang/pe/master/files/4c7c10ff-bfd4-4f63-aadb-7fb57f8b83bd.png) Based on this rubric, since this feature flaw definitely does cause occasional inconveniece for the user (since without the list, the user will be presented with a lot of bugs while using the program), it should at least be of Medium severity.