search

tyuyang / pe

0 stars 0 forks source link

Bug: No feedback when ingredients search does not find any ingredients #9

Open tyuyang opened 1 year ago

tyuyang commented 1 year ago

To reproduce type in: ingredients search eggs

Expected: A message saying no ingredients are found or something along those lines

Actual:

image.png

There was no feedback message. This was especially startling since nearly every other command tested will have some form of feedback if nothing was found. User cannot be blamed if they thought the program actually hung.

(hihi was a command that I typed in to make sure that there was no infinite loop or something along those lines)

soc-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No output when ingredient not listed is typed as input in ingredients search

image.png

Unsure of how to proceed from this point as I was waiting for awhile in case the program needed some time to search for the ingredient. I had to double check to make sure that the ingredient was not listed by adding another input. It would be good to have a warning prompt that the ingredient is not listed or recognized by the app.

[original: nus-cs2113-AY2223S2/pe-interim#262] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Out of scope because command works as expected (all ingredients with "lamb" in the title are listed, i.e. none), but better error messages would be helpful for future versions.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Under this guideline: ![image.png](https://raw.githubusercontent.com/tyuyang/pe/master/files/75a9f5f8-8ef4-4850-a120-c202e8d47a2b.png) this bug should not be under very low severity since this bug does affect normal usage of the application, and is not a purely cosmetic bug. In fact, you can even argue that this is of severity medium since it does cause inconvenience to some users (as evidenced by more testers than just me being confused by the program), just that I did not refer to the rubrics during the PE.