tyx021 / pe

0 stars 0 forks source link

Confusing error message #3

Open tyx021 opened 1 year ago

tyx021 commented 1 year ago

Reproduce: appointment add --p 5 --s 2023-05-01 0700 --e 2023-05-01 0800 --v Dose 1 (Moderna)

Error message: Patient cannot take the vaccination, user might not understand what does this mean. Assumption should be stated, or displayed in error message

image.png

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message for appointment making does not specify the problem.

If I try to make an appointment where the patient does not meet the requirements for, I have to find out on my own what I am missing, and why the appointment failed.

image.png


[original: nus-cs2103-AY2223S2/pe-interim#3132] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The error message specifies that the cause of the error is that the patient cannot take the vaccine given in the appointment, which can be due to multiple reasons:

  • Patient is too young/old
  • Patient has already taken that dose of vaccine.
  • Patient has not taken the dose that is required before taking this dose of vaccine.
  • etc.

This error message is issued to cover these cases which is why it is not in scope.

To find out more about the patient and vaccine, you can use the patient detail and vaccination detail commands

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]