search

tyxla / Gravity-Forms-Multiple-Form-Instances

Allows multiple instances of the same form to be run on a single page when using AJAX.
GNU General Public License v2.0
37 stars 23 forks source link

Fix bug where multiple non-ajax forms, with validation errors, breaks conditional logic. #29

Open mellodave opened 6 years ago

mellodave commented 6 years ago

This happens when there are more than one form on the page, and at least one of them is set to submit without ajax. If this submission results in validation errors, then the original code was setting $_POST['gform_random_id'] for all of the forms on the page, not just for the one that was failing. This resulted in, among other things, conditional logic for all but the last form on the page, to break (because window['gf_form_conditional_logic'] was being overwritten by every form).

This fix tries to detect when a $_POST['gform_random_id'] takes place, and only re-use that id for the form that originally had it. All other forms get new random ids.

The only use case that I could find that is still problematic is when there are more than one form of the same type on the page, and one is set to submit via ajax, and the other is not. This doesn't work - all forms of the same type need to use the same submission methods (ajax, or non-ajax). Forms of different types, however, can be set to have different submission methods, without a problem.

puremana commented 3 years ago

Thanks for this! Took awhile to realize this was the issue but your solution looks to be working great.