tzachar / cmp-tabnine

TabNine plugin for hrsh7th/nvim-cmp
MIT License
287 stars 28 forks source link

use `show_prediction_strength` #41

Closed goolord closed 2 years ago

tzachar commented 2 years ago

This toggle is redundant, and is a leftover from an earlier version. I think the right approach is to completely remove the toggle, and keep the current behaviour as is -- always include the details in the data.detail field. It is up to the user to add the pct into the entry format anyway -- see the format implementation of the readme.

goolord commented 2 years ago

hmmm prediction strength always appears for me regardless of what format returns

goolord commented 2 years ago

this is on HEAD master tzachar/cmp-tabnine image

            format = function(entry, vim_item)
                vim_item.kind = lspkind.presets.default[vim_item.kind]
                if entry.source.name == 'cmp_tabnine' then
                    vim_item.kind = ''
                end
                return vim_item
            end

or with format unset image

goolord commented 2 years ago

unless i'm intended to overwrite vim_item.menu, but it seems like that complicates my configuration for what is ultimately a +3 change upstream

goolord commented 2 years ago

it would be even better if prediction strength was opt in imo. the prediction strength text has 0 utility; it's not going to effect weather or not i (the user) am going to select that entry. it's kinda cool, but it's just noise

tzachar commented 2 years ago

OK. I get your point. Can you please add something regarding this in the README? Some explanation of the option is in order. And make the option false by default.