use arch instead of uname on macos

tzachar / cmp-tabnine

TabNine plugin for hrsh7th/nvim-cmp

MIT License

286 stars 27 forks source link

use arch instead of uname on macos #64

Closed goolord closed 2 years ago

goolord commented 2 years ago

this is an admittedly roundabout way of solving an issue i encountered

when in a nix shell, uname can be provided by gnu-coreutils. in mildly older versions of gnu-coreutils, uname had a bug that identified m1 macs as having an x86 architecture. this solves that by using arch provided by macos insted of uname

tzachar commented 2 years ago

hi @goolord I had to revert this commit as it caused troubles (#65 ) Can you please weight in?

goolord commented 2 years ago

that's very odd.. apologies for the inconvenience this caused. i can't work out why this would make the install script fail. surely x86_64-apple-darwin is the expected result

tzachar commented 2 years ago

Can you recreate the bugs encountered in #64?