search

tzachar / compe-tabnine

TabNine source for hrsh7th/nvim-compe
BSD 3-Clause "New" or "Revised" License
52 stars 3 forks source link

Setup proper permissions for TabNine executables #12

Closed freehaha closed 3 years ago

freehaha commented 3 years ago

This is the behaviour of TabNine's installation script. Deep completion won't be available without setting up other executables (on linux at least. haven't tested on MacOS/Windows). We can set perms on individual executables but since TN's own install script does this already, might as well do the same.

TabNine's download script: https://github.com/codota/TabNine/blob/master/dl_binaries.sh

tzachar commented 3 years ago

I dont think that is enough. The TabNine process would need to know where the original executable sits using realpath(3). Do you know if this is the strategy employed?

freehaha commented 3 years ago

Yes, the TabNine sym-linked executable will find the other binaries just fine.

tzachar commented 3 years ago

Cool. Already merged. 10x.