tzachshabtay / MonoAGS

AGS (Adventure Game Studio) reimagined in Mono
https://tzachshabtay.github.io/MonoAGS/
Artistic License 2.0
27 stars 8 forks source link

Extract Sprite to its own component #206

Closed tzachshabtay closed 6 years ago

tzachshabtay commented 6 years ago

Extract Sprite from the animation component to its own component. The animation component will have a dependency on the Sprite component and will set the Sprite through it.

ghost commented 6 years ago

Does this assume moving Border and DebugDrawPivot to Sprite component?

I noticed that Border property also affects few other classes, such as ButtonAnimation. E: Actually, GUI skins use AnimationComponent.Border a lot.

tzachshabtay commented 6 years ago

I'm not sure if we want to have the border in the sprite or in a separate border component. Separate component might make more sense as we'll be able to give borders for custom renderers which are not sprites. As for DebugDrawPivot, I want to eventually completely replace it with #81 , which I guess we'll also implement as a custom renderer in a separate component.

ghost commented 6 years ago

What I mean is, since we were talking about some minor refactoring, that would make renderers use SpriteComponent's contents instead of AnimationComponent, I could move these two properties into SpriteComponent as the first step.

tzachshabtay commented 6 years ago

Sure, it's up to you.

tzachshabtay commented 6 years ago

Resolved by #211