tzachshabtay / MonoAGS

AGS (Adventure Game Studio) reimagined in Mono
https://tzachshabtay.github.io/MonoAGS/
Artistic License 2.0
27 stars 8 forks source link

Remove "adventure layer" from IObject #217

Closed ghost closed 6 years ago

ghost commented 6 years ago

This PR strips "adventure layer" from the default IObject type in the engine. This "layer" is actually represented only by IHotspotComponent that contains interaction setup (reaction to player commands). The idea is to have IObject as a base class for something that has visuals, but not necessary associates with adventure genre (interaction schemes). The adventure-specific class could be added later (based on Object and having HotspotComponent, and maybe other things).

Besides removing IHotspotComponent from IObject, I had to do following changes:

ghost commented 6 years ago

I just realized that although I removed IHotspotComponent inheritance from the IObject interface, I did not remove it from implementation.

tzachshabtay commented 6 years ago

Right, that needs to be fixed.

ghost commented 6 years ago

Updated.

Oh, had to rebase.

tzachshabtay commented 6 years ago

Looks good, though I think you missed the comment about adding the "seealso" tag.

ghost commented 6 years ago

But I added it. Or there's something else needed here? Maybe github shows cached commit contents?

tzachshabtay commented 6 years ago

Oh, sorry, I see it now. Ok, merging.