search

tzachshabtay / MonoAGS

AGS (Adventure Game Studio) reimagined in Mono
https://tzachshabtay.github.io/MonoAGS/
Artistic License 2.0
28 stars 8 forks source link

Suggestion: merge MathUtils and MathHelper classes #221

Open ghost opened 6 years ago

ghost commented 6 years ago

MathUtils and MathHelper classes partially duplicate each other. I was trying to use MathUtils and did not find particular method (RadiansToDegrees), so ended up implementing it on my own, and later found that method already existed in MathHelper.

Is there anything that prevents combining them in one class?

tzachshabtay commented 6 years ago

MathHelper is part of OpenTK. It's currently copied to AGS.API for technical reasons (like all other classes in the OpenTK folder). It's temporary- OpenTK are planning to split the library into modules, one of them will be OpenTK.Math (see here: https://github.com/opentk/opentk/issues/360). Once that happens I'll be able to use OpenTK.Math and delete MathHelper and the rest of the classes from the API.

Until that happens, I don't want to touch anything in that class, as it will make things harder later on.