search

tzachshabtay / MonoAGS

AGS (Adventure Game Studio) reimagined in Mono
https://tzachshabtay.github.io/MonoAGS/
Artistic License 2.0
27 stars 8 forks source link

Suggestion: rename ISound.Seek to Position #248

Closed ghost closed 6 years ago

ghost commented 6 years ago

This is a proposal to rename ISound.Seek property to Position, as something that could be more recognizable ("seek" seem to refer to an action that changes position). Although Audio backend interface has another meaning for "position", it is refered to as "Panning" in the ISound interface, so hopefully should not cause conflicts.

tzachshabtay commented 6 years ago

Looks good.

Can you change the AGS cheat sheet as well? https://github.com/tzachshabtay/MonoAGS/blob/master/Docs/articles/ags-cheat-sheet.md

And also the article on audio? https://github.com/tzachshabtay/MonoAGS/blob/master/Docs/articles/audio.md

Thanks.

ghost commented 6 years ago

Ammended docs.

ghost commented 6 years ago

@tzachshabtay , I think you made a mistake and merged master to my pull request branch nstead?

ghost commented 6 years ago

Oh, I think I see what's the problem is. I will rebase my pr again.

tzachshabtay commented 6 years ago

I used Github's automatic "Resolve Conflicts" button which indeed merged master to your PR to resolve the conflicts. Not an issue for me personally, but as you rebased, even better.

ghost commented 6 years ago

Did not know this button does that.

Some project teams don't like it when master branch gets merged other way into pr branch creating extra merge commits there, so I grew a habit to avoid it.

tzachshabtay commented 6 years ago

Yeah, I totally get that, merge commits are extra noise. But I'm opting for a more lenient approach, as I sometimes find that the effort in keeping things clean is more costly than just keeping the merge commits (not to mention that it's also less risky -> if somebody decided to branch from your branch and then you rebased, that kind of sucks).