search

tzachshabtay / MonoAGS

AGS (Adventure Game Studio) reimagined in Mono
https://tzachshabtay.github.io/MonoAGS/
Artistic License 2.0
27 stars 8 forks source link

Remove strict requirement for a specific dotnet core version #286

Closed tzachshabtay closed 6 years ago

persn commented 6 years ago

You probably already know but I think the Appveyor build is failing because the source code contains a project using Portable Class Libraries, which is phased out by Microsoft. It should be converted to the new .csproj standard

tzachshabtay commented 6 years ago

I knew they were phasing it out, but I didn't know that was the reason for the error (which is not really revealing). Thanks! I'll convert the project to the new format, then.

persn commented 6 years ago

I don't know for sure, I'm just guessing from the error message.

tzachshabtay commented 6 years ago

It makes perfect sense, and I wanted to convert the project anyway eventually.

Technically, it should work with PCLs as Microsoft wants to keep backwards compatibility with them as far as I know, but it's also the most likely candidate of something that they neglect to maintain with new changes.

persn commented 6 years ago

New errors, hooray. I'm able to reproduce them on my own computer by running dotnet build, not sure why it happens however.

tzachshabtay commented 6 years ago

I think this is why: https://bugzilla.xamarin.com/show_bug.cgi?id=58254 I'll try switching to msbuild restore.

Note, though, that dotnet core is not yet supported, only mono (which uses dotnet core tooling), so dotnet build is not the command to run, but dotnet msbuild (to my best understanding).