Consider renaming of template type name CALLBACK

[arasatalar]

Windows SDK defines "CALLBACK" macro and it leads to compilation errors when used as template type names.
I propose a simple renaming and attach the patch (only a small part of it) to clarify what I mean. Thanks..

diff --git a/include/phtree/phtree.h b/include/phtree/phtree.h index 7a418d4..a1516d9 100644 --- a/include/phtree/phtree.h +++ b/include/phtree/phtree.h @@ -240,9 +240,9 @@ class PhTree {

• sub-nodes before they are returned or traversed. Any filter function must follow the
• signature of the default 'FilterNoOp`. */ - template <typename CALLBACK, typename FILTER = FilterNoOp> - void foreach(CALLBACK&& callback, FILTER&& filter = FILTER()) const { - tree.for_each(std::forward(callback), std::forward(filter)); + template <typename CALLBACK_FN, typename FILTER = FilterNoOp> + void for_each(CALLBACKFN&& callback, FILTER&& filter = FILTER()) const { + tree.for_each(std::forward(callback), std::forward(filter));

[tzaeschke]

Thanks for reporting. I'll have a look.

[tzaeschke]

Could you try out this branch? https://github.com/tzaeschke/phtree-cpp/tree/fix/142-rename-callback-parameter

[tzaeschke]

It seems to work now, but in addition you have to either #define NOMINMAX, or as preprocessor option with /DNOMINMAX, or #include "phtree/phtree.h" before including windows SDK headers.

[arasatalar]

Thanks, quick you are. I will try it soon (already tried a very similar one and worked so should be ok).

And for the the NOMINMAX issue, we already added the preprocessor flag to resolve the issue some time ago. Thanks for the info.

[arasatalar]

Checked it, seems perfect.. Thanks for the quick response. Best

[tzaeschke]

@arasatalar Thanks!