The constructor of FilterSphere is a bit unusual and probably wrong:
FilterSphere(
const KeyExternal& center,
const ScalarExternal& radius,
radius should probably not be a reference. It could be a universal reference though, in case that is desirable. It should probably
mainly accept primitive values.
radius should probably be double or float
center should probably be a universal reference to accept rvalues. If it is a reference, we should actually store it as a reference and not copy it.
The constructor of FilterSphere is a bit unusual and probably wrong:
radius
should probably not be a reference. It could be a universal reference though, in case that is desirable. It should probably mainly accept primitive values.radius
should probably bedouble
orfloat
center
should probably be a universal reference to accept rvalues. If it is a reference, we should actually store it as a reference and not copy it.