Improve the API for PhTreeMultiMap. The current API expects filters that can filter nodes or entries.
The multimap uses collections ("buckets") at each coordinate to store multiple values.
As a result, the current implementation calls the filter once for every entry in every candidate bucket.
This is correct but inefficient.
Many filters will constrain on the coordinate (e.g. FilterSphere). It would be efficient if such a filter would be called only once per bucket, not once per entry in the bucket.
The new API enforces filters with three filter methods:
IsNodeValid(...) filters nodes.
IsEntryValid(...) filters buckets. It is called ...Entry... because each bucket is an entry in the internal PhTree.
IsBucketEntryValid(...) filters entries in buckets.
Improve the API for
PhTreeMultiMap. The current API expects filters that can filter nodes or entries. The multimap uses collections ("buckets") at each coordinate to store multiple values. As a result, the current implementation calls the filter once for every entry in every candidate bucket. This is correct but inefficient.Many filters will constrain on the coordinate (e.g.
FilterSphere). It would be efficient if such a filter would be called only once per bucket, not once per entry in the bucket.The new API enforces filters with three filter methods:
IsNodeValid(...)filters nodes.IsEntryValid(...)filters buckets. It is called...Entry...because each bucket is an entry in the internalPhTree.IsBucketEntryValid(...)filters entries in buckets.This change breaks the API.