Use ESP's logging API - Githubissues

tzapu / WiFiManager

ESP8266 WiFi Connection manager with web captive portal

http://tzapu.com/esp8266-wifi-connection-manager-library-arduino-ide/

MIT License

6.59k stars 1.97k forks source link

Use ESP's logging API #1135

Open nikeee opened 4 years ago

nikeee commented 4 years ago

Basic Infos

Hardware

WiFimanager Branch/Release:

[ ] Master
[x] Development

Esp8266/Esp32:

[ ] ESP8266
[x] ESP32

ESP Core Version: 2.4.0, staging

[ ] 2.3.0
[ ] 2.4.0
[x] staging (master/dev)

Description

Currently, WiFiManager uses a custom logging infrastructure to log stuff: https://github.com/tzapu/WiFiManager/blob/e454c9969a327bcf1be221d19380381e08ca515c/WiFiManager.h#L561-L594

However, ESP-IDF offers an API for logging (which is also part of Arduino): https://thingpulse.com/esp32-logging/

It offers tagging (which would be *WM) as well as setting the verbosity at compile time as well as runtime.

Is this something that could be used? If so I'd be hapy to do a PR.

tablatronix commented 4 years ago

Definitely , I have thought about that, if you can think of a way to simply modify the outputs of the existing logger functions?

I would rather not replace them in case we ever support another micro etc.

Maybe just swap wm serial output via a define to ESP_ logs instead, and maybe we can add a variable prefix to pass also instead of *wm

Alternative would be to redefine the logging functions at compile time. But I have a few weird ones.. Like key,value pairs