tzapu / WiFiManager

ESP8266 WiFi Connection manager with web captive portal
http://tzapu.com/esp8266-wifi-connection-manager-library-arduino-ide/
MIT License
6.6k stars 1.98k forks source link

Enable temp support for ESP32-S3 #1629

Open roleroz opened 1 year ago

roleroz commented 1 year ago

PLEASE TRY Latest Master BRANCH before submitting bugs, in case they were already fixed.

Issues without basic info will be ignored or closed!

Please fill the info fields, it helps to get you faster support ;)

if you have a stack dump decode it: https://github.com/esp8266/Arduino/blob/master/doc/Troubleshooting/stack_dump.rst

for better debug messages: https://github.com/esp8266/Arduino/blob/master/doc/Troubleshooting/debugging.rst

----------------------------- Remove above -----------------------------

Basic Infos

Hardware

WiFimanager Branch/Release: Master

Esp8266/Esp32: ESP32-S3-devkitc-1 (although it should apply to all ESP32-S3 boards and modules)

Hardware: ESP32-S3

Core Version: v5.0.1 esp-idf, head at WifiManager

Description

Problem description

Temperature sensor in ESP32-S3 is disabled when defining WM_NOTEMP in https://github.com/tzapu/WiFiManager/blob/3a303eeb45de78dba9987808bc5bef6440a0f8f8/WiFiManager.h#L56

When ESP32-S3 was released, there wasn't any support for the temperature sensor APIs for that module, so the WM_NOTEMP macro was introduced to disable any temperature support in WM. Since August last year (i.e. starting with esp-idf v4.4, https://github.com/espressif/arduino-esp32/pull/6994), the support for the temperature sensor APIs has been added to the S3's support

Given this, we should re-enable temperature sensor support for the S3 when using a v4.4 or newer instance of esp-idf

Settings in IDE

Any settings will create this, as the temperature sensor disabling is hardcoded in the code

Sketch

#BEGIN
#include <Arduino.h>
#include <WifiManager.h>

void setup() {}

void loop() {}
#END

Debug Messages

In file included from src/main.cpp:14:
.pio/libdeps/esp32-s3-devkitc-1/WiFiManager/WiFiManager.h:55:2: warning: #warning "WM_NOTEMP" [-Wcpp]
 #warning "WM_NOTEMP"
roleroz commented 1 year ago

Any news on this one?